-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checkbox): implement-dark-themes #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't copy the entire source code for each light theme. Rather include the light mixin and modify just the parts that need modifying.
@@ -1,34 +1,20 @@ | |||
@use '../../styles/utilities' as utils; | |||
@use 'checkbox.fluent.scss' as light-checkbox; | |||
|
|||
@include light-checkbox.theme(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should rather be included in the theme mixin.
Closes #149